RADY: Add delete image data (metadata) option at SOPStudyInstanceID level - Githubissues

IUSCA / SQAN

Scalable Quality Assurance for Neuroimaging - (SQAN): A full-stack system solution for extracting, translating, and logging (ETL) + web portal-based quality-control verification of DICOM-formatted medical imaging data/metadata.

https://sqan.sca.iu.edu/

Other

8 stars 3 forks source link

RADY: Add delete image data (metadata) option at SOPStudyInstanceID level #98

Closed agopu closed 5 years ago

agopu commented 5 years ago

Similar to how we allow template level deletion, except we will only allow this at the exam (SOPStudyInstanceID ) level.

aiavenak commented 5 years ago

How do we keep track of data that has been deleted?

agopu commented 5 years ago

Flag in the DB with a deleted=true boolean or perhaps move to a separate table(s) with a _deleted suffix?

aiavenak commented 5 years ago

If the exam is deleted, there is nowhere to fag that it was deleted... I could create a new collection with the same model used for the exams collection, but we only use it for deleted exams.

aiavenak commented 5 years ago

Users can delete an exam from the Exam's view; A comment must be entered, explaining why the data will be deleted. All deleted exams are copied in the DB, from the Exam collection into the Deletedexams collection, with a deletion timestamp and comment.

See https://github.com/IUSCA/rady-ops/issues/22 for screenshot.

aiavenak commented 5 years ago

I still can't figure out how to refresh the Exam's page to reflect the deletion of data

agopu commented 5 years ago

Andrea demo'ed this on andrea.sca ;
Arvind feedback
- [x] 1) Let's get Mike to test, then deploy to prod, then have John test this with a couple of datasets incl. a) same results expected based on same template b) possibly updated results could be expected if newer template found
- [x] 2) Could we show 'deleted' + comment on 1) audit trail? 2) on Exams view? Andrea: Could leave Exam record while deleting all series, this would allow that. Let's do this unless we're missing something.

aiavenak commented 5 years ago

Deleted exams still show up in exam view, and an info button shows details about the deletion:

See https://github.com/IUSCA/rady-ops/issues/22 for screenshot.

agopu commented 5 years ago

This is excellent!

aiavenak commented 5 years ago

Remaining issues/questions to address:

Do we want deleted exams to appear at the bottom, or should they appear according to the exam timestamp?
@youngmd - I need some help refreshing the page after an exam is deleted

agopu commented 5 years ago

Do we want deleted exams to appear at the bottom, or should they appear according to the exam timestamp?

I'd suggest leaving it in the normal order.

youngmd commented 5 years ago

Exam deletions are now reflected in the detail view and in the sidebar without having to refresh the page manually. I also tested that reingestion of deleted exam data still properly registers.

I've pushed the exam deletion feature into the develop branch and it will be included in the next production release. Nice work on this @aiavenak