Garbled speech in Popful Mail with r700

[GoogleCodeExporter]

When playing Popful Mail with GenPlus GX 1.7.0 r700, the PCM audio that plays 
when you meet Slick near the start of the game is glitchy. Note that this audio 
is fine with r683!

Original issue reported on code.google.com by JJBu...@gmail.com on 18 Jul 2012 at 8:00

[GoogleCodeExporter]

Please try with r691 and then with r692 and see if the bug appeared with this 
revision.

Original comment by ekeeke31@gmail.com on 18 Jul 2012 at 9:15

[GoogleCodeExporter]

I'm trying to compile the revisions you've requested and am having trouble. I 
previously downloaded a precompiled r683 and r700, and haven't tried compiling 
on my own. Anyway, when trying to compile, I get these errors:

gx_video.c
In file included from 
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:46:0:
c:/Users/Jeff/devkitpro/portlibs/ppc/include/png.h:1:9: error: expected '=', 
',', ';', 'asm' or '__attribute__' before '/' token
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:60:3: warning: data 
definition has no type or storage class [enabled by default]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:60:3: warning: type 
defaults to 'int' in declaration of 'png_image' [-Wimplicit-int]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1010:32: error: 
unknowntype name 'png_structp'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1010:53: error: 
unknowntype name 'png_bytep'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1010:69: error: 
unknowntype name 'png_size_t'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c: In function 
'gxTextureOpenPNG':
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1027:3: error: unknown 
type name 'png_structp'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1027:3: warning: 
implicit declaration of function 'png_create_read_struct' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1027:48: error: 
'PNG_LIBPNG_VER_STRING' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1027:48: note: each 
undeclared identifier is reported only once for each function it appears in
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1031:3: error: unknown 
type name 'png_infop'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1031:3: warning: 
implicit declaration of function 'png_create_info_struct' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1034:5: warning: 
implicit declaration of function 'png_destroy_read_struct' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1041:5: warning: 
statement with no effect [-Wunused-value]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1041:15: error: 
expected ';' before 'image'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1042:5: error: 'image' 
undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1046:5: warning: 
implicit declaration of function 'png_set_read_fn' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1046:30: error: 
'png_voidp' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1046:41: error: 
expected expression before ')' token
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1046:51: error: 
'png_read_from_mem' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1051:5: error: unknown 
type name 'png_byte'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1058:5: warning: 
implicit declaration of function 'png_sig_cmp' [-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1065:5: warning: 
implicit declaration of function 'png_init_io' [-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1066:5: warning: 
implicit declaration of function 'png_set_sig_bytes' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1075:3: warning: 
implicit declaration of function 'png_read_info' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1078:3: warning: 
implicit declaration of function 'png_get_image_width' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1079:3: warning: 
implicit declaration of function 'png_get_image_height' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1080:3: warning: 
implicit declaration of function 'png_get_bit_depth' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1081:3: warning: 
implicit declaration of function 'png_get_color_type' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1087:24: error: 
'PNG_COLOR_TYPE_RGB_ALPHA' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1111:3: error: unknown 
type name 'png_bytep'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1111:30: error: 
'png_bytep' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1111:41: error: 
expected expression before ')' token
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1122:21: warning: 
assignment makes integer from pointer without a cast [enabled by default]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1126:3: warning: 
implicit declaration of function 'png_read_image' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1129:3: warning: 
implicit declaration of function 'png_read_end' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c: In function 
'gxTextureWritePNG':
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1290:3: error: unknown 
type name 'png_structp'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1290:3: warning: 
implicit declaration of function 'png_create_write_struct' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1290:49: error: 
'PNG_LIBPNG_VER_STRING' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1298:3: error: unknown 
type name 'png_infop'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1302:5: warning: 
implicit declaration of function 'png_destroy_write_struct' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1310:3: warning: 
implicit declaration of function 'png_set_IHDR' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1310:71: error: 
'PNG_COLOR_TYPE_RGB_ALPHA' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1311:16: error: 
'PNG_INTERLACE_NONE' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1311:36: error: 
'PNG_COMPRESSION_TYPE_DEFAULT' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1311:66: error: 
'PNG_FILTER_TYPE_DEFAULT' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1314:3: error: unknown 
type name 'png_bytep'
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1314:30: error: 
'png_bytep' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1314:41: error: 
expected expression before ')' token
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1325:21: warning: 
assignment makes integer from pointer without a cast [enabled by default]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1329:3: warning: 
implicit declaration of function 'png_set_rows' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1332:3: warning: 
implicit declaration of function 'png_write_png' 
[-Wimplicit-function-declaration]
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1332:34: error: 
'PNG_TRANSFORM_IDENTITY' undeclared (first use in this function)
c:/Users/Jeff/devkitpro/genplus691/source/gx/gx_video.c:1335:3: warning: 
implicit declaration of function 'png_write_end' 
[-Wimplicit-function-declaration]
make[1]: *** [gx_video.o] Error 1
make: *** [build_wii] Error 2

I assume the problem is with the "libpng-1.5.4-ppc" file I downloaded. I'm 
pretty sure I got the correct version. Can you lend me some help with this?

Original comment by JJBu...@gmail.com on 18 Jul 2012 at 11:24

[GoogleCodeExporter]

Have you followed the steps in the Compiling section ? Seems like you are 
missing a few libraries or included files, make sure libogc is properly 
installed as well.

Anyway, about the issue, could you upload a savestate just before it happens so 
i can quickly try to reproduce it when i have some time ?

Original comment by ekeeke31@gmail.com on 19 Jul 2012 at 11:31

[GoogleCodeExporter]

These compiling errors are irritating! I have installed devkitPro with the msys 
tools, devkitPPC in devkitpro\devkitPPC, libogc and libfat in devkitpro\libogc, 
and zlib, libpng, and tremor in devkitpro\portlibs\ppc. Am I missing something 
here?

Here is a savestate right before the audio in question plays. Just walk to the 
right and it will start (I saved this with the 1.7.0 binary on this Google Code 
site).

Original comment by JJBu...@gmail.com on 19 Jul 2012 at 4:11

Attachments:

• popful.zip

[GoogleCodeExporter]

Thanks for the savestate.

No idea why it wouldn't compile, i do not have updated libpng for ages and 
compile under windows. The error seems to be in included file png.h (line 9), 
all following errors are then due to missing libpng declarations since that 
file was not interpreted correctly. 
Check comments in Compiling section as i think an user also had some issues 
with badly extracted library files.

Original comment by ekeeke31@gmail.com on 20 Jul 2012 at 11:34

[GoogleCodeExporter]

I have some news: I downgraded libpng from 1.5.4 to 1.4.1 and can now compile 
GenPlus GX with no errors (finally!). Why was the newer version giving me 
trouble? The builds seem to function without error, so using the older version 
doesn't seem to be an issue.

So, I tested r691 and r692. r691 plays the PCM audio perfectly and r692 has the 
glitchy stuttering issue, so whatever changes were made to pcm.c at that point 
negatively affected the game, but fixed others like Panic!/Switch.

Original comment by JJBu...@gmail.com on 21 Jul 2012 at 4:12

[GoogleCodeExporter]

Thank you for testing. I have no way no test or code anything for the time 
being but will try to found what went wrong in these changes. I noticed screen 
freezing issues in Snatcher (old factory section) which seem ro be related to 
pcm emulation as well.

As for libpng, i don't know what is wrong with the last version and don't 
really care honestly, it's only used to display menu images anyway, old 
versions are perfectly fine. The error seems to indicate a problem in png.h, 
not an incompatibility from the emulator with libpng,  so maybe it is not 
compatible with devkitppc or it's missing something.

Original comment by ekeeke31@gmail.com on 21 Jul 2012 at 9:02

• Changed state: Accepted
• Added labels: Priority-Medium, SCDEmulation, Type-Defect

[GoogleCodeExporter]

It was actually a stupid C coding mistake I made, should be fixed in r701.

Original comment by ekeeke31@gmail.com on 21 Jul 2012 at 5:12

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by ekeeke31@gmail.com on 22 Jul 2012 at 5:48

• Changed state: Verified