IVCTool / IVCT_Framework

For IVCT Framework Developers. Core System for the IVCT (Integration, Verification and Certification Tool) for HLA Federates
Apache License 2.0
16 stars 4 forks source link

Empty catch block in execute() of AbstractTestCase #42

Closed rmauget closed 7 years ago

rmauget commented 7 years ago

The AbstractTestCase class contains the following source code:

public IVCT_Verdict execute(final String tcParamJson, final Logger logger) {

               IVCT_BaseModel ivct_BaseModel = null;
               IVCT_Verdict ivct_Verdict = new IVCT_Verdict();

               try {
                              ivct_BaseModel = getIVCT_BaseModel(tcParamJson, logger);
               } catch (TcInconclusive e) {
               }

When there is a problem while calling getIVCT_BaseModel(), no error message is logged because the catch section is empty. So the user is not informed that there is an error.

Is it possible to log an error?

ducana commented 7 years ago

The catch block has been changed to log a message as suggested. A number of similar catch blocks have been fixed in other parts of the test system.