search

IacobIonut01 / Gallery

Light-weight Media Gallery app for Android made with Jetpack Compose
Apache License 2.0
1.21k stars 61 forks source link

[Enhancement] Add Albums #285

Open shomykohai opened 9 months ago

shomykohai commented 9 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I found in this app the best compromise of features and UX, but in my opinion adding custom albums it would make it even better! to happen.

Describe the solution you'd like A clear and concise description of what you want to happen.
Adding albums the same way Google photos does:

Create an album and give it a name Put inside of it any picture you want

Possibly it would be nice to have a way to lock the album via either a pin or the preferred system unlock option (e.g biometrics) and to export the albums in some way so whenever someone uninstalls and reinstalls the app or switches to a new phone, they can import back the albums.

Additional context Add any other context or screenshots about the feature request here.
There's already the possibility to do something like that with favorites, but I'd like to group some of my pictures in different albums without having to move them in different directories.

newhinton commented 9 months ago

I second that.

I think it would be best to rename the current "album" feature to "Folders" or something similar, and create a new feature allows for custom albums. This way those two features are seperate.

shomykohai commented 9 months ago

I second that.

I think it would be best to rename the current "album" feature to "Folders" or something similar, and create a new feature allows for custom albums. This way those two features are seperate.

This is a great idea to me! Though I'd probably put them in the same tab as folders with a button for albums or even just a scrollable horizontal list with all the albums, something like Google photo already does with folders in the "library" tab!

newhinton commented 6 months ago

@IacobIonut01 I am willing to try work on this.

However, it seems that the "album"-nomenclature is pretty deep baked into the code. Is there any deeper meaning behind that choice? I have replaced album with folders in my initial test, but maybe that is not a good idea.

IacobIonut01 commented 6 months ago

@IacobIonut01 I am willing to try work on this.

However, it seems that the "album"-nomenclature is pretty deep baked into the code. Is there any deeper meaning behind that choice? I have replaced album with folders in my initial test, but maybe that is not a good idea.

The app reflects the data that the MediaStore uses, so the 'albums' are indeed folders. Working on this feature would require way more time and effort than actually opening a File Manager or actually from the Gallery App (with move/copy actions) to create new 'albums' and categorise the pictures you like in them directly. From my honest opinion adding both 'Folders' and Custom Albums is useless unless they are dynamically made (location based albums etc - which are planned)

newhinton commented 6 months ago

From what i can see, i imagine custom albums working like "Favorite". It is always created from the database, and that database only contains a album<->media-id pairing. On a first glance, that doesn't seem like too much effort to me. Though: I have not yet worked with compose, so that part is new to me and i might missjudge the actual effort.

Also, dynamic albums don't really solve this specific usecase.

For me: I want to group pictures together that dont have a connection besides what it is in them. Also no exif-locations ;) The only way i can achieve that is by manually adding to an album.

If you generally dont oppose to this feature, i am going to give it a try. Though if you really don't want it, i'd like to know so that i dont spend time on something that is not helpful to you.

shomykohai commented 6 months ago

@IacobIonut01 I am willing to try work on this.

However, it seems that the "album"-nomenclature is pretty deep baked into the code. Is there any deeper meaning behind that choice? I have replaced album with folders in my initial test, but maybe that is not a good idea.

The app reflects the data that the MediaStore uses, so the 'albums' are indeed folders. Working on this feature would require way more time and effort than actually opening a File Manager or actually from the Gallery App (with move/copy actions) to create new 'albums' and categorise the pictures you like in them directly. From my honest opinion adding both 'Folders' and Custom Albums is useless unless they are dynamically made (location based albums etc - which are planned)

In my opinion custom albums wouldn't be useless considering that, first of all, is a feature that galleries like Google Photo or Photos from Apple allow. Surely dynamic ones based on common Metadata / topic are a good feature to add, but also letting the user choose how to manage the pictures without having to moving them in another directory or having duplicates.

newhinton commented 6 months ago

Great!

Then i'll try my best. Also i am going to keep the "album"-naming, and the new custom-album one is going to be that, "custom album" internally, but user facing, i like "your albums"

IacobIonut01 commented 6 months ago

I don't oppose the feature itself, so you can do it in the end if you would like to, also it wouldn't require any UI changes other than the one required to add/remove/create albums and inserting media to them, most of the work is in the local database. If you fail to do the feature, I will get back to it after the top-priority stuff is done (Photo&Video editor, media-grid rework)