search

IacobIonut01 / Gallery

Light-weight Media Gallery app for Android made with Jetpack Compose
Apache License 2.0
1.05k stars 57 forks source link

[WIP] Feature/285/customgallery #368

Open newhinton opened 3 months ago

newhinton commented 3 months ago

This implements #285

newhinton commented 3 months ago

@IacobIonut01

I have now implemented the core functionality of custom albums. They are based on the original albums, and not every feature works. (Eg. pinning, album previews)

Besides a code-review, there is also a bit of cleanup todo, especially for the strings, since i changed albums to folders. There are probably quite a few missing. My reasoning for this is that it makes more sense, since it actually behaves exactly like the folders in a files app. Also, having three different "album" types might be confusing (Folders, custom albums, dynamic albums)

IacobIonut01 commented 3 months ago

I'll review this weekend and do the changes accordingly. Thanks

IacobIonut01 commented 3 months ago

Opening media inside the custom albums also don't work

newhinton commented 3 months ago

Opening media inside the custom albums also don't work

Oh yeah, i can see that. I'll take a look later!

newhinton commented 3 months ago

Hm, i only used the TimelineScreen like the album does. I cant see whats wrong, sorry