'Pin' option should *not* be cleared when the 'x' clear icon is clicked

[tanstaafl]

Hi Iago,

Again, thanks so much for Unified Search! I just wish the devs would see its value and incorporate its functionality in the core code...

Anyway, there are 3 niggling little issues I still have with Unified Search that are not consistent with the way the Quick Filter Toolbar works - I'll open up a separate issue for each one...

This one is per the subject - if I 'pin' the searchbox, it should stay pinned until I intentionally unpin it...

Meaning, currently, if I enter a search term, then pin the searchbox, when I click the 'x' to clear the search term, it also clearns the 'pin' selection. When using the Quickfilter Toolbar searchbox, clicking the 'x' to clear the search term does not clear the 'pin' selection.

Thanks for listening!

[IagoSRL]

Hi Tanstaafl,

Yes, it happens. The cause is that, if in qfb you do a 'triple Esc key', pin is cleared too (is the 'full filtering options clearing'), for unified search widget I just choose do a 'single Esc key' that does the full clear, meaning that also pin option is reseted. But, just now (Thunderbird 9, I think also happen at 8 version but not previous), there is a different behavior with the simple, double and triple 'Esc key' at Thunderbird (involves select a quick-filter option like 'attachments', 'contacts', etc.), and because I just do some calls to Thunderbird native functions this means that the behavior I expected for Unified Search Widget is different.

I will use this issue just to try to restore the original behavior (one click, all reseted), but not clearing pin option never.

Really, from a time I think that the sticky-pin can be not needed, can be suprissed from Thunderbird and convert it in the unique behavior: ever persist filtering across folders, and filtering must be reset manually (clear button click or Esc key) if someone don't want continue filtering; this will remove the 'auto clearing behavior' that happens now when pin is not checked, meaning that an extra step is needed. It's only an idea, some programs do something like this and it seems not so problematic.

Thanks to you for the feedback!

[tanstaafl]

Hi Iago,

One more tiny little suggestion...

Could you move the 'Pin' icon from the right side of the searchbox to the left side? More than once I have accidentally clicked it instead of the 'x'/clear button... not that it is a big problem when I do this, but it is annoying...

Or, maybe, instead of inside the searchbox, it would be more consistent to put it on the far left of the Filter Options panel (to the left of the 'Show Unread/Read...' button), since this is where it is on the QF Toolbar?

[tanstaafl]

And while we're at it (simplifying and optimizing it for hopeful inclusion in the core code)...

I still have to keep the 'View: ' Widget on the toolbar, because it allows me to set a specific view on a per folder basis (it is persistent, ie, it remembers the view setting (All, Unread, etc) for each individual folder across sessions.

Would it be crazy to think about incorporating the functionality of this widget into the Unified Search addon? It also has the ability to create/save custom 'Views' on the fly (which creates a Virtual Folder).

I know on the surface that sounds like making it more complicated, but on the whole, incorporating this functionality into the Addon would eliminate the redundancy in the widget (it also has the Show All/UnRead only toggle), and the need for the View widget totally (assuming we can get it incorporated into the core code).

Anyway, it was just a thought...

Definitely, though we need to get the Addon simplified/stable first, before attempting that (could be your next project)... I really wish I was a programmer, I think I'd enjoy doing this kind of thing (but I just don't have the time or the patience)...

As always, thanks for listening to my ramblings...

[IagoSRL]

Hi Charles,

Maybe in the future, after learn about save session preferences per folder, and with current dev stable.

About pin icon on the left, I want prepare some UI concepts, one of then with pin on left and one without that icon (filtering ever persistent), with others ideas. I expect have time next days snd upload it to bugzilla like a new only testing extension.

And, answering your last comment at bugzilla, each beta version I can have of Unified Search I will send you, thanks for testing.

Regards, IagoSRL

El 06/01/2012, a las 15:47, tanstaaflreply@reply.github.com escribió:

And while we're at it (simplifying and optimizing it for hopeful inclusion in the core code)...

I still have to keep the 'View: ' Widget on the toolbar, because it allows me to set a specific view on a per folder basis (it is persistent, ie, it remembers the view setting (All, Unread, etc) for each individual folder across sessions.

Would it be crazy to think about incorporating the functionality of this widget into the Unified Search addon? It also has the ability to create/save custom 'Views' on the fly (which creates a Virtual Folder).

I know on the surface that sounds like making it more complicated, but on the whole, incorporating this functionality into the Addon would eliminate the redundancy in the widget (it also has the Show All/UnRead only toggle), and the need for the View widget totally (assuming we can get it incorporated into the core code).

Anyway, it was just a thought...

Definitely, though we need to get the Addon simplified/stable first, before attempting that (could be your next project)... I really wish I was a programmer, I think I'd enjoy doing this kind of thing (but I just don't have the time or the patience)...

As always, thanks for listening to my ramblings...

---

Reply to this email directly or view it on GitHub: https://github.com/IagoSRL/TBX-Unified-Search/issues/13#issuecomment-3385307