search

IagoSRL / TBX-Unified-Search

Thunderbird extension that unify the features of global search box and quick filter box in an unique widget.
https://addons.mozilla.org/es-ES/thunderbird/addon/unified-search-187593/
6 stars 3 forks source link

Add underscore to tooltips to show accesskey #28

Closed oeekker closed 10 years ago

oeekker commented 10 years ago

When translating TBX-Unified-Search I noticed there were two hidden shortcuts, one for converting the menubar into a menu and one to toggle the pin to keep filters applied. Those two items don't have labels, so the accesskey isn't shown. I added some code to show the accesskey in the tooltip text, by creating a html tooltip with an underlined accesskey...

IagoSRL commented 10 years ago

Thanks, good point! Let me review it over the weekend.

I hope to being able to work more on the issue12 branch too to do a new release, because without that cannot be uploaded to AMO.

oeekker commented 10 years ago

Thanks, take your time! I'm going on vacation this weekend so I won't be around if you need help understanding the patch, but it's pretty straightforward.

I added some hoops on case the accesskey doesn't occur in the tooltiptext. I think it's now done the same way as for labels.

I also had some problems getting the underlined character. I first tried it with a but that didn't work. I thought the tag was deprecated.

I got most of the code from this page: https://developer.mozilla.org/en-US/Add-ons/Code_snippets/HTML_in_XUL_for_rich_tooltips

Onno

On 2 jul. 2014, at 17:02, IagoSRL notifications@github.com wrote:

Thanks, good point! Let me review it over the weekend.

I hope to being able to work more on the issue12 branch too to do a new release, because without that cannot be uploaded to AMO.

— Reply to this email directly or view it on GitHub.