search

Iakobs / godot-play-game-services

A Godot 4.2 plugin for integration with Google Play Game Services
MIT License
82 stars 5 forks source link

Many class names clash with commonly used names #11

Closed bryanmylee closed 5 months ago

bryanmylee commented 5 months ago

It would be great if all the classes used in this plugin had a specific prefix, like PGS or something. There are a lot of names used that conflict with my existing code, e.g. Player.

Although, it's not too much of an issue as I can just modify the files directly.

Iakobs commented 5 months ago

Hi @bryanmylee thanks a lot for your suggestion, that's very true indeed! I will change them as soon as I can.

bryanmylee commented 5 months ago

My bad, seems like Godot was just confused about some of the conflicting class names. A few restarts seem to solve the conflict with the nested class definitions, since most of the classes have the PlayGames prefix.

Thanks so much for your hard work!