search

IamManchanda / gulp-webpack

Gulp 4 + Webpack 4 + Babel + BrowserSync + Font Awesome 5 (Modern JavaScript + Sass/CSS)
155 stars 48 forks source link

Browser-sync #24

Open pawelmiklas opened 5 years ago

pawelmiklas commented 5 years ago

Browser-sync on html is not working. On sass files is okey.

skaltenegger commented 5 years ago

@IamManchanda great work! Is there any way you could take a look at this issue - would make this package so much better!

Ps.: https://github.com/IamManchanda/gulp-webpack/blob/master/gulpfile.js#L211 might have a small typo and should be gulp.watch(srcPath('html', true)) - am I right?

Super glad to hear your feedback! Best, Stefan

skaltenegger commented 5 years ago

@snaqu in case you need a quick fix: The change from my answer above plus the following change (inserting another browserSync.reload)

// Watch - Markup
    gulp.watch(srcPath("html"), true).on(
      "all",
      gulp.series(
        Object.assign(cleanMarkup(mode), {
          displayName: `Watching Markup Task: Clean - ${modeName}`
        }),
        Object.assign(buildMarkup(mode), {
          displayName: `Watching Markup Task: Build - ${modeName}`
        }),
        browserSync.reload // INSERTED
      ),
      browserSync.reload
    );

did the job for me - hope that helps!

IamManchanda commented 5 years ago

Thanks a lot guys! Sorry I had no idea that this project got love ... will surely dig next weekend

Thanks for your feedback ... will look into these!