search

IamManchanda / gulp-webpack

Gulp 4 + Webpack 4 + Babel + BrowserSync + Font Awesome 5 (Modern JavaScript + Sass/CSS)
154 stars 48 forks source link

gulp-imagemin error #28

Open kirkbross opened 5 years ago

kirkbross commented 5 years ago

SOLVED: at the end of the buildImages function, I changed:

], done) : undefined

to:

], done()) : undefined

This project is awesome btw. I was having no problems and then suddenly it starting gulp-imagemin starting crashing npm start.

If I remove all the images from my src/img folder and then npm start, it runs fine. If I add the images back, or new new images while it's running, all is good. It's only if I CTRL+C stop and then npm start again that I get the below error.

I'm running Windows 10 with latest node and npm.

gulp-imagemin: Minified 22 images (saved 38.9 kB - 1.7%) [21:19:36] The following tasks did not complete: default, Booting Images Task: Build - Production Mode [21:19:36] Did you forget to signal async completion?

IamManchanda commented 5 years ago

Thanks will surely see this next weekend and other issues ... Again thanks for making me figure out that this repo got love ... I had no idea honestly!

Apologies for that!

emisrw commented 5 years ago

I also have a problem with gulp-imagemin. It does not copy all images, only part. I would also consider adding a cache for photos and compress only new.