search

IamTheFij / release-gitter

https://git.iamthefij.com/iamthefij/release-gitter
MIT License
1 stars 2 forks source link

Allow defining the `destination` field in configuration #4

Closed amitds1997 closed 2 weeks ago

amitds1997 commented 10 months ago

I am trying to use this package to provide GitHub release pre-commit hook for selene just like StyLua.

The problem: selene release packages the binary selene and that conflicts with the top level folder selene in the repo. So, the error is:

IsADirectoryError: [Errno 21] Is a directory: '<local-path>/selene/selene'

This does not happen when using the CLI command because it allows specifying destination.

Reproduction steps

  1. Clone amitds1997/selene
  2. Run pip wheel . directly or in a virtualenv

Possible resolution

  1. Allow passing destination in pyproject configuration (source).
  2. Pass destination to download_asset call.
IamTheFij commented 2 weeks ago

Sorry, I totally lost track of this and noticed it when looking at selene myself! Rather than making the download destination configurable, I'm instead using the build directory. That should achieve the same goal of avoiding conflicting file names.