IanCheah / pe

0 stars 0 forks source link

Sequence diagram in DG #8

Open IanCheah opened 2 weeks ago

IanCheah commented 2 weeks ago

I noticed that there are 2 sequence diagrams under section 3.3.1 Implementation - Sequence Diagrams. Screenshot 2024-11-15 172257.png I think that it should made clear to the user that the bottom picture is supposed to be a continuation of the seqeunce diagram above. The Note: The lifeline.... made me think that the bottom sequence diagram refers to a new part (unrelated to the diagram above). Furthermore, as the sequence diagram is large, it makes it difficult to read.

My recommnedation would be to shorten the names of the parameter in the methods so as to fit all of them in 1 picture.

nus-pe-script commented 2 weeks ago

Team's Response

Reason the note is below the first sequence diagram is because the second diagram does not have any X. Furthermore, it is already stated in the first line of the section that both diagrams belong to the Tag command sequence.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi, despite having stated in the first line that both diagrams belong to the Tag, I do not think that helps with the clarity at all. It is difficult to trace through the sequence given that it is top down.