search

IanLunn / Hover

A collection of CSS3 powered hover effects to be applied to links, buttons, logos, SVG, featured images and so on. Easily apply to your own elements, modify or just use for inspiration. Available in CSS, Sass, and LESS.
http://ianlunn.github.io/Hover/
Other
29.25k stars 5.78k forks source link

fix deprecation warning in mixin #115

Closed HongPong closed 7 years ago

HongPong commented 7 years ago

I got the sass compiler to quit freaking out at me by wrapping the unquote parameters in #{} .

@mixin prefixed($property, $value) {
  -webkit-#{$property}: unquote(#{$value});
  #{$property}: unquote(#{$value});
}

Errors similar to:

DEPRECATION WARNING: Passing 0.3s, a non-string value, to unquote()
will be an error in future versions of Sass.
DEPRECATION WARNING: Passing perspective(1px) translateZ(0), a non-string value, to unquote()
will be an error in future versions of Sass.
IanLunn commented 7 years ago

What version of Hover.css and Sass are you using please? Latest version of Hover.css doesn't use unquote().

HongPong commented 7 years ago

Ah, I'll close the ticket. This was a little while back - I believe it was in a child theme of this project https://www.drupal.org/project/zurb_foundation Which at the time was probably on Foundation 6.2.x and the packages it installed. I thought I had the most recent version of this at the time, but perhaps not!