search

IanLunn / Hover

A collection of CSS3 powered hover effects to be applied to links, buttons, logos, SVG, featured images and so on. Easily apply to your own elements, modify or just use for inspiration. Available in CSS, Sass, and LESS.
http://ianlunn.github.io/Hover/
Other
29.25k stars 5.78k forks source link

Scss version doesn't include webkit/moz versions?? #16

Closed joepagan closed 10 years ago

joepagan commented 10 years ago

Am I missing something?

The hover.css version includes the webkit/moz calls, though the scss version doesn't? Is there a scss version I can't see?

It would be so useful to use includes on elements rather than adding a class in my markup.

IanLunn commented 10 years ago

prefixes are added using the autoprefix package for Grunt. If you have it set up, you can run grunt in a command line. Whenever you edit .scss files, Grunt will automatically prefix and compile the CSS.

If there's enough call for it (or you want to set it up yourself), we can set up a non Grunt version that uses mixins to prefix aswell.

joepagan commented 10 years ago

Hey Ian,

Thanks for getting back to me, oh that would explain why they aren't there.

That's fair enough, though I don't use grunt myself so I would certainly prefer to use mixins.

Might be worth setting up a 2nd branch for non-grunt users if you think most people will be using grunt.

Yeah I would be happy to help, I use git, though I'm yet to help out on a github repo. Will try do something in the not too distant future. Though I'll let you decide what you would like to do first.

IanLunn commented 10 years ago

Ok, no problem.

It's a simple project so want to keep it as easy to use as possible. I'll set up some mixins either in additional files or a second branch.

joepagan commented 10 years ago

Cool, thanks Ian, if you want to maybe commit with the mixins you want for transitions/transforms/animations etc then I can try do some. Don't think there's any point using bourbon/compass's as you don't know what people want to use, so might be worth creating the mixins with some slightly less-obvious names incase they conflict "hovTransition" for example.

joepagan commented 10 years ago

Oh and thanks so much for making this, some really nice effects <3 it!

IanLunn commented 10 years ago

1.0.8 removes Grunt's autoprefixer task in favour of SASS mixins. Use @include prefixed(property, value) and @include keyframes(keyframe-name) { /* keyframes content */ } mixins to prefix any necessary properties. Find these in scss/_mixins.scss.

Checkout README.md for further info.