search

IanLunn / Hover

A collection of CSS3 powered hover effects to be applied to links, buttons, logos, SVG, featured images and so on. Easily apply to your own elements, modify or just use for inspiration. Available in CSS, Sass, and LESS.
http://ianlunn.github.io/Hover/
Other
29.25k stars 5.78k forks source link

Alphabetization of properties #46

Closed awelch83 closed 9 years ago

awelch83 commented 9 years ago

I've alphabetized properties for all classes in hover.css and demo-page.css. I've also updated hover-min to reflect the changes that I made to hover.css.

IanLunn commented 9 years ago

Thanks for your work @awelch83 but I don't think this improves the project -- not everybody writes their properties in alphabetical order (I personally don't). It also means additional work to apply the same to the Sass and LESS formats.

awelch83 commented 9 years ago

It improves the project by making it more readable for future contributors. That's how. See below:

https://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml#CSS_Style_Rules

That was a nice 1+ hours wasted. Thanks for the warm welcome. I have no desire to be involved with this project anymore.

IanLunn commented 9 years ago

Sorry you feel that way @awelch83. I appreciate your work and I'm sure you haven't wasted your time as no doubt others will like the library formatted in this way too. I will be sure to point them to your pull request. Of course, if lots of people request this, I will reconsider but for now my reason for not merging is because alphabetization isn't a standard. Not everybody works in this way.

renege commented 9 years ago

@awelch83 http://css-tricks.com/poll-results-how-do-you-order-your-css-properties/