IanPhilips / UnityOculusAndroidVRBrowser

3D browser based on GeckoView and Oculus SDK for Unity projects built on Android (Oculus Go/Quest, maybe GearVR)
MIT License
225 stars 63 forks source link

Support text input with system keyboard #38

Closed sienori closed 2 years ago

sienori commented 3 years ago

Hi, I implemented text input using the system keyboard!

Changes

https://user-images.githubusercontent.com/29514424/139308083-e325aee5-262a-42d1-a0d1-52365199904c.mp4

Known issues

IanPhilips commented 3 years ago

Hey sienori, thanks for the PR! Interesting you can't detect backspace, does _keyboard.text not pass the backspaced text? Or, in other words, what is the problem with not detecting the backspace - do we have to detect it and send the appropriate keycode?

IanPhilips commented 3 years ago

I also noticed you didn't add the rebuilt plugin, so I'll add that. And maybe that's a better trust model perhaps standard with these situations. I just built the project on my Oculus Go and no keyboard is showing up. That may just be an issue with Oculus Go though, I don't have a quest to try it out with. Do you have a Go to try it out in? Are there any configuration steps needed in ether scene or should it 'just' work?

Abhishek8Chili commented 2 years ago

Will try this on a quest today and report.

IanPhilips commented 2 years ago

any luck @Abhishek8Chili ?

clovelt commented 2 years ago

This works wonderfully! All known issues have been fixed in subsequent Oculus updates, as of v35 both unfocus keyboard and backspace works perfectly.

IanPhilips commented 2 years ago

Thanks for submitting @sienori and thanks for testing it @clovelt!