search

IanQS / krak_trader

Automated Kraken Trader
2 stars 1 forks source link

Scraper enhancements #27

Closed bryantpq closed 6 years ago

bryantpq commented 6 years ago
IanQS commented 6 years ago

Hmm, I'd prefer if this was broken into more bite-sized chunks. Clump errors that should be handled together in new issues, and things that are pretty large open new individual issues.

1) Logging should be its own issue (except it already exists so that's fine)

2) removing BS and using lxml should be own issue since that's pretty large (or at least that's the impression I get from what you said)

3) abnormal halting and preprocessors for cleaning garbage can probs go into a news_scraper_enchancements PR

IanQS commented 6 years ago

sorry didn't mean to close it. LMK what your thoughts are re what I said about splitting it up. If you have a good reason for keeping it all together I'd like to hear about it :)

bryantpq commented 6 years ago

I just wanted to have it all in one place, i forgot what labels are for. My bad, i'll reopen them as new issues