search

IanTeo / cs3219-Project

0 stars 0 forks source link

Clashes authors of same name but different casing #20

Closed Zhiyuan-Amos closed 7 years ago

Zhiyuan-Amos commented 7 years ago

Your issue title does not make sense to me also, you are allowing us to print the original version of the author name right?

Yup correct ah. What's the issue? If it's just issue with the issue title, that one you can change it ba cos I just typed it quickly.

Edit: What's issue title? Or PR title?

Zhiyuan-Amos commented 7 years ago

@IanTeo

IanTeo commented 7 years ago

No issue, just saying I didn't understand when I first looked at it

Zhiyuan-Amos commented 7 years ago

Haha I see xD sorry ah I couldn't quite think of how to better phrase it.

Zhiyuan-Amos commented 7 years ago

Anws without tests we really run the risk of code not working. Previously using 'contains' instead of 'equalsIgnoreCase' is quite wrong actually.

Cos if we are looking for 'icse' and the venue is 'abcicseabc' , it passes the contains method.

So... We really should write tests. :P eyeball very hard la bro haha