search

IanVS / eslint-nibble

Ease into ESLint, by fixing one rule at a time
MIT License
787 stars 29 forks source link

Thoughts on moving away from `eslint-summary`? #107

Closed TheBox193 closed 2 months ago

TheBox193 commented 1 year ago

Background

eslint-summary provides the summary line for eslint-nibble. image

While eslint-nibble has been maintained, eslint-summary has not for ~8yrs. For example eslint-nibble is using "chalk": "^4.1.1" while eslint-summary is still on "chalk": "^1.0.0".

The functionality of eslint-summary is rather straightforward. Does it make sense to adopt and pull this code into eslint-nibble?

This came to my attention when looking through my repos dependencies and vulnerabilities and chasing down where older versions of chalk where coming from.

Thoughts?

I would be happy to open a PR & add some unit tests if there is interest. 🙂

IanVS commented 1 year ago

That sounds like a good idea. Normally I'd suggest submitting a PR upstream, but the author has not been on GitHub for years it looks like, so I think that would be fruitless. I'd be happy to accept a PR that pulls it into eslint-nibble itself. Thanks for the offer.