search

IanVS / eslint-nibble

Ease into ESLint, by fixing one rule at a time
MIT License
787 stars 29 forks source link

package.lock.json size #84

Closed egracens closed 3 years ago

egracens commented 3 years ago

It is not an issue. Just wondering. Is it OK that package.lock.json has a size of 13k lines?

ljharb commented 3 years ago

Yes, it’s ok and expected, and has nothing to do with this repo specifically.

egracens commented 3 years ago

There are 916 lines of JS code and 13k lines of dependencies in this repo. If it is OK for JS projects in general then we live in the mad world 😄

image

IanVS commented 3 years ago

That's not quite accurate. I'm sure there are many more lines of javascript in the dependencies, but I'm guessing the tool you ran does not include node_modules. The package.lock.json file describes the dependencies, and you can learn more about it at https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json.

Another thing to keep in mind, many of those dependencies are development tools, and are not used in the actual runtime of eslint-nibble.

But at the end of the day, this isn't a meme for no reason:

image

ljharb commented 3 years ago

More deps is better :-)