search

Ianleeclark / notorious

Go: A feature-complete, performant torrent tracker
MIT License
212 stars 17 forks source link

Add torrent-client whitelisting #40

Open Ianleeclark opened 8 years ago

Ianleeclark commented 8 years ago

A lot of private trackers tend to whitelist or blacklist specific clients (transmission 2.90 as of right now) so this is a much needed feature.

anacrolix commented 8 years ago

Do you know why this is done?

Ianleeclark commented 8 years ago

Trackers will typically enable Whitelisting because they feel a peer using a specific client isn't safe. The safety can be toward the peer (for example, disallowing a torrent client that has known malware) or toward the torrenting community/tracker (for example disallowing the newer versions of utorrent). These are the two most common reasons a tracker would white list clients or blacklist clients On Apr 8, 2016 04:28, "Matt Joiner" notifications@github.com wrote:

Do you know why this is done?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/GrappigPanda/notorious/issues/40#issuecomment-207347306

anacrolix commented 8 years ago

This was a deep rabbit hole that lead to reading about uTorrent going bad, and Xunlei and other bad clients. Thanks.

If you begin a whitelist or blacklist, the values for github.com/anacrolix/torrent are to be found here: https://github.com/anacrolix/torrent/blob/master/global.go#L14 (recommend whitelist obviously).

Ianleeclark commented 8 years ago

Haha, I feel the same way about writing this entire tracker. Plus one you ever dive into http specifications your always bound to learn something.

Thanks for the recommendation, anacrolix wrote a really solid library so I'll definitely check out the Whitelisting section. On Apr 14, 2016 02:20, "Matt Joiner" notifications@github.com wrote:

This was a deep rabbit hole that lead to reading about uTorrent going bad, and Xunlei and other bad clients. Thanks.

If you begin a whitelist or blacklist, the values for github.com/anacrolix/torrent are to be found here: https://github.com/anacrolix/torrent/blob/master/global.go#L14 (recommend whitelist obviously).

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/GrappigPanda/notorious/issues/40#issuecomment-209800131

Ianleeclark commented 8 years ago

Hah. I didn't realise you were anacrolix until just now.