IasonNautica / betterPackOpener

A more accurate pack opener for Yugioh cards
MIT License
1 stars 1 forks source link

[Bug] Banlist Append creates a banlist only from the ydk file #3

Closed Milkamilk closed 3 years ago

Milkamilk commented 3 years ago

The Banlist Append function is broken. It only creates a banlist out of the ydk file and gets rid of the first banlist. In my example below, I created a whitelist from Legend of Blue Eyes White Dragon and appended my pulls from Metal Raiders to it.

Blue-Eyes This is the original banlist created from only Legend of Blue Eyes White Dragon. Here you can see that I pulled 2 Blue-Eyes White Dragon.

AppendBlueEyes Here I attempt to search for Blue-Eyes from the appended whitelist. As you can see, Blue-Eyes is nowhere to be found.

MetalRaiders If I clear my search bar, only cards from Metal Raiders are visible.

Here is my LOB whitelist as well as the appended whitelist as .txt files. LOBWhitelist.txt AppendedList.txt

My process for appending the list was first selecting LOB and generating a pull ydk. Next I created a whitelist using the create whitelist function. Afterwards I selected Metal Raiders and generated a pull. Finally I used Banlist Append, selecting the whitelist created from LOB and the Metal Raiders ydk file.

IasonNautica commented 3 years ago

Hey, thanks for the heads up. This was caused due to some shitty variable naming inside the main function, I've fixed it and will push it to main now. I will make a new release with both of your reports accounted for in a bit