search

Ibercivis / odourcollect.eu

European Union Public License 1.2
1 stars 1 forks source link

Nice odours can have an unpleasant clasification #51

Closed miguelherpas closed 3 years ago

miguelherpas commented 3 years ago

This issue is not a "proper" problem, I just wanted to open a discussion about the fact that nice odours can have an unpleasant classification. I wanted to know your opinion about which is the best way to clarify this situation.

AlexAmoSfC commented 3 years ago

@miguelherpas here's my take on that, IMHO.

Conversely, unpleasant odours can be scored as pleasant. This is a design decision (or lack thereof), that would imply redesigning the list of odour types/subtypes in a way that we should specify if an odour type has to be always positive or always negative. All in all, this is the kind of decisions that have to be took before even writing a line of code IMHO. On top of that, we have to prioritize, and time runs out. Hence, it is with great sorrow that I'd suggest not making any code refactoring to tackle this question, and accept this potential inconsistency for the sake of simplicity.

frasanz commented 3 years ago

I do agree.

On Thu, 27 May 2021 at 11:36, Alex Amo at ScienceForChange < @.***> wrote:

@miguelherpas https://github.com/miguelherpas here's my take on that, IMHO.

Conversely, unpleasant odours can be scored as pleasant. This is a design decision (or lack thereof), that would imply redesigning the list of odour types/subtypes in a way that we should specify if an odour type has to be always positive or always negative. All in all, this is the kind of decisions that have to be took before even writing a line of code IMHO. On top of that, we have to prioritize, and time runs out. Hence, it is with great sorrow that I'd suggest not making any code refactoring to tackle this question, and accept this potential inconsistency for the sake of simplicity.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Ibercivis/odourcollect.eu/issues/51#issuecomment-849489358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADPO7PGRF3M5NF2K7HX7E3TPYHC5ANCNFSM45PTTMSQ .

frasanz commented 3 years ago

I mean, I do agree with Alex's suggestion. There are issues that might be a lot of effort to make (in terms of hours) and short benefit. And we should avoid it at this point.

Fran

On Thu, 27 May 2021 at 11:39, Francisco Sanz García @.***> wrote:

I do agree.

On Thu, 27 May 2021 at 11:36, Alex Amo at ScienceForChange < @.***> wrote:

@miguelherpas https://github.com/miguelherpas here's my take on that, IMHO.

Conversely, unpleasant odours can be scored as pleasant. This is a design decision (or lack thereof), that would imply redesigning the list of odour types/subtypes in a way that we should specify if an odour type has to be always positive or always negative. All in all, this is the kind of decisions that have to be took before even writing a line of code IMHO. On top of that, we have to prioritize, and time runs out. Hence, it is with great sorrow that I'd suggest not making any code refactoring to tackle this question, and accept this potential inconsistency for the sake of simplicity.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Ibercivis/odourcollect.eu/issues/51#issuecomment-849489358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADPO7PGRF3M5NF2K7HX7E3TPYHC5ANCNFSM45PTTMSQ .

AlexAmoSfC commented 3 years ago

If you are OK with that, I proceed to tag as wontfix and close. This does not take the fact that we'll take this shortcoming of the app into account for future iteration on the long run.