Ibit-to / google-unlocked

Google Unlocked browser extension uncensor google search results
https://ibit.uno
2.26k stars 162 forks source link

Unobfuscate JS file #16

Closed RazeLighter777 closed 5 years ago

RazeLighter777 commented 5 years ago

Unobfuscates the javascript file to make it fit the FireFox requirements for extensions

Ibit-to commented 5 years ago

Thanks for your contribution. Can you point out to this specific requirement by Firefox?

capito27 commented 5 years ago

Here is the relevant policy about minified code usage

But since the minified code is not a first party code, but a third party library, i believe this policy applies.

The way I interpret those policies is that if your add-on contains first party minified/obfuscated/machine generated code, you must provide the original source code along with instructions to generate the minified/obfuscated code. This point doesn't seem to apply to this project, since the minified code is a third party library.

The way I interpret the third party library policy, is that you must provide links to the original minified library files, along with their source code, when submitting your add-on for verification.

As such, I feel that this pull request is off topic.

Edit : I just had a look at the proposed commit changes, this is simply a reformatted JS file, it's still as unreadable as before, using non-descriptive variable and function names and such. The actual non-minified js code may be found in this source code, under the "/dist/jquery.js" zip path.

Ibit-to commented 5 years ago

Thanks for the info @capito27

I understand that the PR is based on misinterpretation of the Firefox policy. In addition, this project was taken down from Firefox addons which makes Firefox addon policy irrelevant.

I will close this PR but feel free to reopen if there are new info..