Closed jdvp closed 3 years ago
Or also before I forget, the plugin directive:
com.ibotta:plugin
is a little vague and may cause issues if you want more ibotta plugins later. I'm not too familiar with plugins but you may want to consider renaming it at some point
com.ibotta:aspectj-plugin
Hey there @jdvp,
Happy to hear you were able to use our plugin successfully! In response to your questions:
Or also before I forget, the plugin directive: com.ibotta:plugin is a little vague and may cause issues if you want more ibotta plugins later. I'm not too familiar with plugins but you may want to consider renaming it at some point com.ibotta:aspectj-plugin
Guhh, I couldn't agree more. I'll try to explain what happened here.
We have our plugin being distributed to the "Gradle Plugin Portal", which seems appropriate. In order to do so, you use another Gradle plugin to publish it.
The variables you specify, and what happens with them, was not obvious nor was the documentation particularly helpful. We thought we had it configured with sane values, but had no way to really confirm that without actually releasing the plugin. So we tried that. Then we found out that there are huge delays in getting through the Gradle Plugin Portal approval process (could be weeks). Once we finally got approved after tapping a contact we have at Gradle, we came to find out the plugin identifier was less than desirable.
Honestly, the huge delay in approvals, and the need to figure out the right way to configure the plugin's group identifier, are what made us leave it as is for now. We (Ibotta) need to devote some time to this, unless someone from the community can help out sooner. Wink wink, nudge nudge. If for some reason it causes huge headaches, other than just being unsightly and ambiguous, I could try to push internally for some dedicated time to fix it. As with any open source project though, we are hoping to get some help from the community whenever possible.
@eschlenz Thanks for the quick reply. This all makes a lot of sense to me, so I'm going to update my article's example and project with the Ibotta plugin as a replacement for what I had before.
The bytecode pipeline is pretty interesting so I'll also take a look into it, I never even knew it existed. But I guess that's true for a lot of things that are hidden away in gradle and android builds!
I'm not very familiar with working on plugins themselves but I'll definitely play with this one and maybe one day I'll be able to contribute!
If for some reason it causes huge headaches, other than just being unsightly and ambiguous, I could try to push internally for some dedicated time to fix it.
I don't think this a serious issue, unless it's causing problems for you guys. It is ambiguous but I don't think it will cause any major issues for anyone.
Thanks again and have a nice holiday!
The bytecode pipeline is pretty interesting so I'll also take a look into it, I never even knew it existed. But I guess that's true for a lot of things that are hidden away in gradle and android builds!
It is! We hadn't heard of it either until our Gradle reps pointed us in that direction. In hindsight, it makes sense that such a feature exists.
Hey @eschlenz, I discovered this plugin through your article while actually trying fix a problem with another plugin (lol) by getting away from said plugin, since I was trying to fix my own AOP Sample Application bc new views on one of my older articles would probably expect it to be working properly.
First off, this is very cool and switching plugins was super easy from my end, and worked without any issues. Great work!
My questions are as follows:
Thanks again for the cool plugin! Please feel free to close this issue as you see fit as it's not actually a bug or anything.