Ibotta / mr_uplift

Multiple Response Uplift (or heterogeneous treatment effects) package that builds and evaluates tradeoffs with multiple treatments and multiple responses
Apache License 2.0
66 stars 13 forks source link

Fix Logic Error for Predicting Erupt Curves With New Data #27

Closed samcarlos closed 4 years ago

samcarlos commented 4 years ago

The Current functionality for get_erupt_curves will check to see if any of input data is missing. However this if statement was logically incorrect. The update fixes that issue.

mhorstAK commented 4 years ago

Looks good to me.