Use explicit booster in xgboost test - Githubissues

Ibotta / pure-predict

Machine learning prediction in pure Python

Apache License 2.0

86 stars 7 forks source link

Use explicit booster in xgboost test #4

Closed denver1117 closed 4 years ago

denver1117 commented 4 years ago

Use explicit booster in xgboost test

Description

The xgboost test does not explicitly supply a booster argument. This is required in xgboost 1.0.0.

Motivation and Context

We want to properly test xgboost on the newest version. This change will work for xgboost 1.0.0 and all previous supported versions of xgboost.

How Has This Been Tested?

Travis build has passed.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added reviewers to the PR.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.