search

Ibotta / sopstool

SOPS multi-file wrapper
Apache License 2.0
38 stars 4 forks source link

Ensure plaintext files get cleaned if entrypoint fails. #30

Closed elementalvoid closed 5 years ago

elementalvoid commented 5 years ago

Story/Issue Link

Fixes: #29 -- sopstool entrypoint fails to delete cleartext files on non-zero exit codes

Versioning

Next version should be a patch release as no functionality is changing.

Additional Requests to Reviewers

Add any additional high-level requests for reviewers.

Tasks

/cc

@onyxraven @ibottamike

blimmer commented 5 years ago

Huh, I'm not sure why the test coverage thing wasn't working. I added the requested key to the build and restarted it for ya.

blimmer commented 5 years ago

Ah, actually it looks like it's because of this:

https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

I'll handle that in another PR

blimmer commented 5 years ago

@elementalvoid if you merge master from mainline you'll get the fix to your build! (#31 )