search

Ibotta / sopstool

SOPS multi-file wrapper
Apache License 2.0
38 stars 4 forks source link

Refactor of internal packages for better test and future refactors #35

Closed onyxraven closed 5 years ago

onyxraven commented 5 years ago

Background

A refactoring of some internal packages to help more tests and features in the future.

Also updates a few packages and locks versions to help resolve some dependency hell.

Versioning

Patch - no changed functionality here.

Additional Requests to Reviewers

Some discussion about creating interfaces like these vs injecting and mocking in test that might come up later.

Tasks

/cc

onyxraven commented 5 years ago

Is this PR still active? I'm currently waiting on adding functionality to allow a graceful shutdown of child process by passing SIGTERM and SIGKILL through entrypoint.

yes. The repo currently doesn't have any integration tests, so I need to do some by hand and write down the procedures so they can be written. I've just been putting that off. I'll do that today. You can still base your PR off this branch and we can rebase it.

ibottamike commented 5 years ago

Is this PR still active? I'm currently waiting on adding functionality to allow a graceful shutdown of child process by passing SIGTERM and SIGKILL through entrypoint.

yes. The repo currently doesn't have any integration tests, so I need to do some by hand and write down the procedures so they can be written. I've just been putting that off. I'll do that today. You can still base your PR off this branch and we can rebase it.

Thanks, we have a one-off solution for PWI. I will wait for this and docker-base before rolling it out as part of the Paved Road.

onyxraven commented 5 years ago

Smoke tested, everything looks good.