IbrahimBilal2005 / CampusPulse

0 stars 0 forks source link

Signup Interactors and Tests completed #16

Closed IbrahimBilal2005 closed 1 week ago

IbrahimBilal2005 commented 1 week ago

Completed the signup usecase interactors for both eventposter and user. Also completed the interactor Test classes for both interactors with all relevant test methods.

These test will not pass since we still need to figure out the implementation for interests and tags (combobox, textfield, how many total words to pick, choose from given list or open ended input etc.) These are things we can discuss in lab and then I can implement it into my signup logic.

W-Akrabi commented 1 week ago

can you elaborate on the "need to figure out the implementation for interests and tags" How I implemented my search use case was like: Users enter a keyword into the search bar. Users can specify tags (e.g., "sports, outdoor") using filters. These inputs are passed to the SearchController, which prepares a SearchInputData object containing the keyword (category) and tags. The interactor queries the data access layer using the provided inputs and fetches relevant results. Results Handling:

Results are passed back to the SearchPresenter, which updates the SearchViewModel with either the results or an error message ("No events found"). The Home_screen dynamically updates the UI to display the results.

because we already have a search bar so I personally think that's good enough no?

W-Akrabi commented 1 week ago

Also is the sign up use case affected by the interests and tags?

IbrahimBilal2005 commented 1 week ago

If we want a good filtering system then the tags for event posters and interests for users should be connected.

Signup is where the users pick their interests, and event posters pick their tags.

We were still discussing if we want users to input any interest, or if we want to give them a list of choices to select from.

We were also still discussing if we want to limit how many interests/tags users/event-posters can choose.

We were also discussing if event posters should have generic tags for all their future events, or event specific tags for each event when posting.

That's why for now I didn't implement the interest and tag input sections for signup until we finalize our tags/interests system.

W-Akrabi commented 1 week ago

Ok great. Your unit tests for testing the sign up part if the use case is passing though right? like User data validation (e.g., email format, password strength), Error handling for missing or invalid data, Overall user flow up to where the interests selection is skipped.

IbrahimBilal2005 commented 1 week ago

As mentioned, I can't pass my tests until I can create user and event poster objects. I can't do that until my signup input data and related logic takes tags/interests as mentioned in your account strategy classes. I can't do that until we discuss how we want to structure this process in signup.

The structure and code of the tests is all there, and once we've figured out how to implement interests and tags, and I've incorporated them into the signup process, the tests will pass.

Also it's important to note I'll be adding tests as we go. These are just the most important ones. The other ones you mentioned are additional restraints that don't impact the functionality of the signup process as much (but can still be added to be more thorough)