IbrahimBilal2005 / CampusPulse

0 stars 0 forks source link

Signup user interests implementation + All current tests now passing #20

Closed IbrahimBilal2005 closed 1 week ago

IbrahimBilal2005 commented 1 week ago
IbrahimBilal2005 commented 1 week ago

Do you mind being more specific about where there is high coupling between the UI and business logic?

I'll be adding more edge-case tests as I implement more specific error functionality, so that is already in the pipline, thanks for pointing it out.

W-Akrabi commented 1 week ago

I think im taking coupling a little to seriously but please advise if I'm wrong

IbrahimBilal2005 commented 1 week ago

I'm just not sure which part of the code you're referring to. If there's a specific part that looks like it has high coupling, let me know so I an address it directly

W-Akrabi commented 1 week ago

After reviewing your code further I realized I misinterpreted the genderInputFeild. I believe that your code is perfect and abides by all the principles.

IbrahimBilal2005 commented 1 week ago

Sounds good! Thank you for your attention to detail it's very appreciated :)