search

IcaliaLabs / LoginKit

LoginKit is a quick and easy way to add a Login/Signup UX to your iOS app.
MIT License
662 stars 90 forks source link

Error Builing App #11

Closed boardmain closed 7 years ago

boardmain commented 7 years ago

hi after i install LoginKit from cocoapod

if i try the run the app i have this error in build phase

"FBSDKLoginKit" Incopatible block pointer types 'void(^)(BOOL) to parameter tof type 'void..... line 505 FBSDKLoginManager.m

same error line 549 and 551

boardmain commented 7 years ago

the problem is with the last FacebookCore update with version 4.25.0

likeaj6 commented 7 years ago

also having this issue

danlozano commented 7 years ago

Yeah, it's a Facebook SDK update.

Will update ASAP and get this fixed.

Considering switching to having a fixed Facebook SDK version to prevent this problem, and just update once in a while.

danlozano commented 7 years ago

This is strange...

I finally got the time to look into this.

Went into the sample project and another personal project I have that uses LoginKit. Updated LoginKit via cocoapods (so the Facebook SDK's would update to version 26), everything good.

Now I run the app, hoping it's going to crash because of the Facebook update, so I can go in and fix whatever changed.

But it worked just fine! What am I missing? When does this error come up? Any clues as to what changed?

danlozano commented 7 years ago

Nevermind!

I think the issue is that LoginKit was using the hard-coded-version FBSDKLoginKit .18 , but internally that was using a newer version of FBSDKCoreKit, and that was causing the issue I suppose.

Changed LoginKit to use the newest version of FBSDKLoginKit and it seems to be working now!

:)