Closed thelastinuit closed 6 years ago
We should only have vendored files in our projects as a very fuckin' last resort. I've already rejected some PR's because of this.
If it's absolutely unavoidable, then we must exclude these from the codeclimate configuration.
@thelastinuit each kind of project has their own preferred location for vendored file.
We should add those on their respective fetchable configurations:
Feel free to discuss and propose changes to these files. Be aware these are being actively used by foresight and sibyl-mini, as they are downloaded automatically before each check-run.
We can have a vendor
directory just as Rails do it, so the linters can ignore that. I agree with @vovimayhem on this, it is better to call them via a CDN or from external resources
@vovimayhem language! got it. will do.
@kurenn @vovimayhem
For vendor thingies, is it appropriate to update the respective linters to ignore those files/folders? What should be the protocol for such things?