IcaliaLabs / guides

A set of rules we use at @icalialabs to build better software
295 stars 45 forks source link

ESLint Indentation Rule: 2 vs 4 spaces? #81

Closed vovimayhem closed 6 years ago

vovimayhem commented 6 years ago

https://github.com/IcaliaLabs/guides/blob/aff5952482a2e6e331c726b0f6b3b1188462f316/best_practices/code-analysis/default.eslintrc.yml#L5

For starters, it's the first time I take a serious look at the rule file.

ESLint is expecting us to use 4 spaces instead of 2:

screen shot 2018-06-19 at 6 15 04 pm

My personal preference is 2... Pros? Cons? Which one?

PTAL @kurenn @Sherwell @walreyes @lgevaldez @miguejs @thelastinuit

vovimayhem commented 6 years ago
screen shot 2018-06-19 at 6 19 14 pm
vovimayhem commented 6 years ago
screen shot 2018-06-19 at 6 26 51 pm
vovimayhem commented 6 years ago

So... we're going for 2.