search

IcaliaLabs / guides

A set of rules we use at @icalialabs to build better software
295 stars 45 forks source link

Specs & Migrations #83

Closed thelastinuit closed 6 years ago

thelastinuit commented 6 years ago

@vovimayhem @kurenn

On rubocop y reek, can we ignore the folder specs and db/migrate? Can you explain the reason for including them?

kurenn commented 6 years ago

We should ignore both, unless @vovimayhem has another suggestion for it, can you be so kind and place a PR with the change?

thelastinuit commented 6 years ago

@kurenn the petition is for me or @vovimayhem ?

vovimayhem commented 6 years ago

They are currently being ignored for all checks & plugins:

https://github.com/IcaliaLabs/guides/blob/220449a6ad1c63051a05e56606c79f3dfce8bfe4/best_practices/code-analysis/rails.codeclimate.yml#L85-L86

vovimayhem commented 6 years ago

Although I'm really interested on implementing an engine that enforces this guide:

http://www.betterspecs.org

kurenn commented 6 years ago

@thelastinuit I'm asking you

thelastinuit commented 6 years ago

I run rubocop/reek locally. I didn't have that configuration so I was out of the loop. What @vovimayhem commented resolved this discussion. Thanks y'all.