Icaruk / albion-profit

Albion Profit is a tool that enables users to semi-automatically calculate the profit of any combination of one product with multiple ingredients.
https://icaruk.github.io/albion-profit/
7 stars 0 forks source link

Bug Report: Components for refined resources not appearing #1

Closed spellberry closed 3 weeks ago

spellberry commented 3 weeks ago

Description

The components appear without issue when using the calculator, choosing a craftable item (armor, etc.), and clicking the hammer icon. But whenever I do the same thing for refined resources (bars, planks, etc.), the components don't show. Below is a video, showcasing the problem.

https://github.com/user-attachments/assets/b04c3f0d-be4f-40b1-a523-1ba69ea402cb

Icaruk commented 3 weeks ago

Hi @spellberry Thanks for submitting this issue!

This tool uses the Albion Online API to fetch the required items, unfortunately they have missing fields on some items. Here are some examples (check craftingRequirements field):

I added notifications to give some feedback to the user. At the moment I haven't found a better solution.

image

spellberry commented 3 weeks ago

Ah, I see. That's unfortunate. Still, adding the ingredients manually is not such a big deal. Also, while I am writing here, I wanted to ask what the "Mod%" field is for. And are you planning to add a field for the tax cost for the refine station a player uses? I think these are big QoL features that can make this calculator even better.

Icaruk commented 3 weeks ago

Ah, I see. That's unfortunate. Still, adding the ingredients manually is not such a big deal. Also, while I am writing here, I wanted to ask what the "Mod%" field is for. And are you planning to add a field for the tax cost for the refine station a player uses? I think these are big QoL features that can make this calculator even better.

Then you can add the value and calculation will be done with the bonus: image

100 * 1.37 = 137

Icaruk commented 3 weeks ago

@spellberry I added a tooltip for "Mod %"

image

Icaruk commented 3 weeks ago

@spellberry Good news!

I found a pattern to find required items for each refined resource (except enchanted ones) let me know if it works for you!