IcarusWorks / ember-key-manager

A service for (un)binding keyboard up and down events.

MIT License

42 stars 11 forks source link

prevent empty matching macros to stop events propagation #48

Closed mkamneng closed 5 years ago

mkamneng commented 6 years ago

47 - in the `handleEvent`, the `_findMatchingMacros` can return an empty array. The check for match `if(matchingMacros)` will return true for an empty array result and therefore stop the event propagation for that key pressed. `if(matchingMacros)` replaced with `if(isPresent(matchingMacros))` and test added

patrickberkeley commented 5 years ago

Released in v0.3.3