fix: Do not assume events have an event.key.

IcarusWorks / ember-key-manager

A service for (un)binding keyboard up and down events.

MIT License

42 stars 11 forks source link

fix: Do not assume events have an event.key. #54

Closed jasonmit closed 5 years ago

jasonmit commented 5 years ago

When clicking on an input[type='text'] autocomplete suggestion, the keyUp event is fired but event.key is undefined. This causes some downstream logic that assume key is a string to throw.

This is happening in Chrome 71, unsure if it's a recent browser bug or not.

patrickberkeley commented 5 years ago

Released in 0.3.4