search

IcarusWorks / ember-key-manager

A service for (un)binding keyboard up and down events.
MIT License
42 stars 11 forks source link

Octane compatibility #57

Closed BryanCrotaz closed 3 years ago

BryanCrotaz commented 3 years ago

Upgrade to ember-cli 3.22 Implement with Typescript

patrickberkeley commented 3 years ago

@BryanCrotaz it looks like lint is failing the build. get is unused here: https://github.com/IcarusWorks/ember-key-manager/blob/master/tests/dummy/app/application/controller.js#L4

jordpo commented 3 years ago

Yeah it looks like tests are passing but the linting is not.

patrickberkeley commented 3 years ago

Actually there are a stack of template lint errors (30) and three js lint errors. You can see all here: https://travis-ci.org/github/IcarusWorks/ember-key-manager/jobs/739041561

BryanCrotaz commented 3 years ago

I can't see the travis jobs here, so let me know if it's ok now

jordpo commented 3 years ago

@BryanCrotaz you can see the builds if you click on this link https://travis-ci.org/github/IcarusWorks/ember-key-manager/pull_requests

BryanCrotaz commented 3 years ago

ok I think I'm done.

BryanCrotaz commented 3 years ago

C'est Tout.

May I suggest this now is ready for a 1.0.0 release?

jordpo commented 3 years ago

@BryanCrotaz just published v1.0.0 - https://github.com/IcarusWorks/ember-key-manager/releases/tag/v1.0.0

Nice work!