Duplicated audio - Githubissues

Potajito commented 1 year ago

First of all, thanks for this! It's the best tool for discord streaming I've found so far. No fps drops, good video, audio... But when I stream with audio (first I select the audio, desktop or the app, tried both) but I hear the app twice, for some reason, and I can't seem to be able to silence that second one without silencing the original one. This is using discord on Firefox 115.0.2. Any idea?

IceDBorn commented 1 year ago

Can you post a screenshot of Helvum taken while you're streaming audio?

Edit: Thanks a lot for your kind words, they mean a lot and keep us motivated!

Potajito commented 1 year ago

Hi, qpwgraph for the patches, hope that's ok, as it looks a bit more clear than helvum over here: Screenshot_20230729_212126 This is running discord on Firefox PWA.

IceDBorn commented 1 year ago

Everything looks in order, no errors on Pipewire's side. I can't replicate this, nor any of the other devs, we'll need more information on this problem or at least a way to reproduce it.

Potajito commented 1 year ago

I've done some (lots) of testing, and I could only blame this on discord screen share:

I was using a patched firefox vaapi, so when I realized that I tried plain firefox and developer/nightly, but there was no difference.
Then I tried another webrtc apps, like this demo site (https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing/#9378353810022836) or just jitsi, and that was working fine.
So I guess basically the problem is the discord implementation? When I screen share on discord I get this weird bug where I get prompted twice for the screenshare (looking around, this seems like one permission for the small preview window and another for the actual stream, also you need to select both and can't skip either if you want the actual stream to work). This double prompt thing is probably related to some bugs like:

https://bugzilla.redhat.com/show_bug.cgi?id=1891974 https://bugzilla.mozilla.org/show_bug.cgi?id=1811341

Here I managed to record a video with this behavior:

https://github.com/IceDBorn/pipewire-screenaudio/assets/39760810/486e9896-11dc-4a30-8a4e-16c76cd9caae

IceDBorn commented 1 year ago

How does Discord manage to ruin stuff all the time? Thanks a lot for testing this out btw. I'm currently on vacation, so it'll be a few more days before I can test it out too. Sorry for the inconvenience.

Potajito commented 1 year ago

I almost passed out listening to this... How does Discord manage to ruin stuff all the time? Thanks a lot for testing this out btw. I'm currently on vacation, so it'll be a few more days before I can test it out too. Sorry for the inconvenience.

Hahaha, sorry for that, didn't want to trigger you. No worries, no rush, just drop me a message if you need any testing done. Cheers!

IceDBorn commented 1 year ago

@Potajito Can you join the matrix space? I want you to try some more things.

toboggan7 commented 1 year ago

Everything looks in order, no errors on Pipewire's side. I can't replicate this, nor any of the other devs, we'll need more information on this problem or at least a way to reproduce it.

I was able to reproduce this using Librewolf, but not under standard Firefox. Possibly something with the config, or an issue with PWAs?

IceDBorn commented 1 year ago

I'm using a hardened user.js made by arkenfox, on the other hand, I've overridden some settings for a better overall experience. Maybe one of the settings I've overridden fixes this issue?

IceDBorn commented 1 year ago

I managed to reproduce this on Hyprland, it's not a config issue.

IceDBorn commented 1 year ago

Fixed on latest release

IceDBorn / pipewire-screenaudio

Duplicated audio #16