search

IceDynamix / reliquary-archiver

tool to create a relic export from network packets of a certain turn-based anime game
MIT License
199 stars 19 forks source link

Add more language support #43

Open 12345-mcpython opened 4 months ago

12345-mcpython commented 4 months ago

The default archive_output.json file's " light cone", "relic" and character name is English. I hope to support the other language's data export to use in my tools.

FichteFoll commented 3 months ago

Would it be more helpful if the respective ids were included instead so that you could combine the output with your own language source in your tools?

The export is primarily supposed to machine-readable after all.

IceDynamix commented 3 months ago

language support is easy by simply swapping the textmap

https://github.com/Dimbreath/StarRailData/tree/master/TextMap

https://github.com/IceDynamix/reliquary-archiver/blob/main/src/export/fribbels.rs#L263

adding ids would warrant a separate export format that implements the Exporter trait

https://github.com/IceDynamix/reliquary-archiver/blob/main/src/export/mod.rs#L5

FichteFoll commented 3 months ago

I would argue this is not a backwards-incompatible change with the current fribbles format, but it should probably also be clarified with fribbles first, if the id is something worth adding to the general format and to be prioritized over the current string identifier, which could then of course still be included but would be more of a human-readable fallback id.