search

IceReaper / OpenKrush

A KKnD and KKnD2 mod on OpenRA engine.
https://kknd-game.com
GNU General Public License v3.0
99 stars 6 forks source link

Update Laser. #24

Closed GraionDilach closed 5 years ago

GraionDilach commented 5 years ago

No longer ignores height. Use WDist for SegmentLength. Fix LaserRenderable.OffsetBy. Recode the math behind distortion. Clarify a TODO comment. Remove unnecessary private definitions. And fix a typo.

Also, VS fixed the spaces/tabs mixup so I advise you to use ?w=1 on the diff.

GraionDilach commented 5 years ago

I'm not sure if the distortion calculation is correct though, since I dunno KKND. I guess you might want to tweak it further (by offsetting with a rotated vector vertical to beam direction instead of what it is now, that's open for discussion).

GraionDilach commented 5 years ago

Should be. What was your aim with the segments though? Just found out that @forcecore already provided the necessary math to segment stuff based on a ring plane during the laser...

GraionDilach commented 5 years ago

Which comment to what broken boolean?