IceWhaleTech / CasaOS

CasaOS - A simple, easy-to-use, elegant open-source Personal Cloud system.
https://casaos.io
Apache License 2.0
25k stars 1.35k forks source link

[Bug] unable to connect to SMB share. The password contains characters eg !@#! #1152

Closed giveaduck12 closed 12 months ago

giveaduck12 commented 1 year ago

Describe the bug Trying to connect to SMB share. The password contains characters eg !@#!

To Reproduce Steps to reproduce the behavior:

  1. Go to Connect Network Storage
  2. Type SMB address and username and PW with !@#! characters
  3. Click on Connect
  4. See error: Special characters may cause security problems

Expected behavior connects to SMB share

Screenshots (https://i.imgur.com/Sg4hgPf.png)

Desktop (please complete the following information):

Logs nil

LinkLeong commented 1 year ago

Which version of casaos do you have?

LinkLeong commented 1 year ago

We will close this question and reopen it if you have any questions

davidstosik commented 1 year ago

@LinkLeong I have reproduced that error with CasaOS 0.4.4. I suspect characters such as ; or ], present in my SMB password, to be the cause.

slackerchris commented 1 year ago

@LinkLeong I too am have the same issue, password contains @ and !

roeberp commented 1 year ago

Doesn't like the $ for me.

Djuuu commented 1 year ago

Same issue on v0.4.4.1 My username contains only letters, password contains only letters, digits and spaces.

In any case, forbidding characters in a password field is bad practice.

cleanmachine commented 1 year ago

I took delivery of a ZimaBoard last week and was trying to connect to both my Synology NAS and my TrueNAS box via the Connect Network Storage function in the Files app in CasaOS 0.4.4.1. Both my local network storage boxes have long, strong passwords using the full range of characters, as is good practice. I, too, got the "Special characters may cause security problems" popup and the connect button greyed out.

LinkLeong commented 1 year ago

I have followed the issue and I will continue to do so.

cleanmachine commented 1 year ago

Thank you. I should note that the username for both my network storage accounts is the same - a five-letter, lowercase word using no caps, numerals or special characters. It's only the passwords that are long (30+ characters) and strong (upper and lower case, numbers and special characters).

LinkLeong commented 1 year ago

This issue was fixed in 0.4.4-2, and the update is still in beta, so you can update manually if you need to. curl -fsSL https://get.casaos.io/update/v0.4.4-2 | bash

cleanmachine commented 1 year ago

Excellent - thank you.

On Tue, Sep 12, 2023 at 11:50 PM link @.***> wrote:

This issue was fixed in 0.4.4-2, and the update is still in beta, so you can update manually if you need to.

— Reply to this email directly, view it on GitHub https://github.com/IceWhaleTech/CasaOS/issues/1152#issuecomment-1716899881, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQH3CQH5ECNIEH6D4SU5KDX2EUQFANCNFSM6AAAAAAYUB7RMM . You are receiving this because you commented.Message ID: @.***>

LinkLeong commented 12 months ago

I'll close this question and reopen it if you have any questions.

cleanmachine commented 12 months ago

Reporting in that this works now. Thanks for your efforts.