IceWhaleTech / CasaOS

CasaOS - A simple, easy-to-use, elegant open-source Personal Cloud system.
https://casaos.io
Apache License 2.0
23.95k stars 1.31k forks source link

[Bug] Pi-Hole upgrade broken #1255

Open jaknz opened 1 year ago

jaknz commented 1 year ago

Describe the bug

Bug: App store 0.4.3 installer for Pi-Hole puts data in /DATA/AppData/Pi-hole/ whereas the new 0.4.4 installer puts data in /DATA/AppData/pihole/. This means even if you keep the data when removing the docker-cli version, you're still going to be reset to defaults.

To Reproduce

Steps to reproduce the behavior:

  1. Start on CasaOS v0.4.3
  2. Install Pi-Hole
  3. Upgrade CasaOS to 0.4.4
  4. Remove Pi-hole, KEEPING DATA
  5. Reinstall Pi-hole
  6. New data location means app is reset to defaults

Expected behavior

Reinstalling the app links back to the original DATA directory.

Screenshots

N/A

Desktop (please complete the following information):

 - OS: Debian aarm64
 - Browser: Irrelevant 
 - Version: N/A

System Time

Run timedatectl and share the output

irrelevant

Logs

Run following command to collect corresponding logs:

sudo journalctl -xef -u casaos-gateway
sudo journalctl -xef -u casaos-user-service
sudo journalctl -xef -u casaos-local-storage
sudo journalctl -xef -u casaos-app-management
sudo journalctl -xef -u casaos.service

Additional context

This is something that should have been vetted in alpha stage and should not have even made it to the beta app store.

CorrectRoadH commented 1 year ago

😭Yes, we actually broke compatibility. Because we changed the application installation package. It may be difficult for us to fix it, because it has already been released, and the problem is due to our lack of thoughtfulness. Currently you can only fix it manually.

mcdullmedia commented 1 year ago

Is it possible for us to revert if we still not yet remove the old container? i.e. can we just wait until 4.5 or 4.4.1 to fix the issue then we mirgate the legacy container?