IceWhaleTech / CasaOS

CasaOS - A simple, easy-to-use, elegant open-source Personal Cloud system.
https://casaos.io
Apache License 2.0
26.32k stars 1.44k forks source link

The "Legacy app (To be rebuilt)" containers should be viewable via the "Widget Settings" menu #1333

Open rodhammond opened 1 year ago

rodhammond commented 1 year ago

Build: Latest

Discussion: This vue should be selectable [Hidden/Visible] by the "Widget Settings" menu to be activated based on the user's wishes. Not all containers can be "rebuilt" or imported into CasaOS. It's seems you are forcing the import feature rather than giving the user options. Anyone can build containers using "docker run" or "docker compose" and they will exist outside of the CasaOS App Store, but easily accessible via external dashboard tile links.

For containers that do not work or cannot be imported into CasaOS, your "Legacy app (To be rebuilt)" message cannot be hidden or disabled. Please re-enable the visibility feature. I could be mistaken, but believe it use to be selectable by the user.

Code: CasaOS-UI/main/src/components/Apps/AppSection.vue title="Legacy app (To be rebuilt)."

ETWang1991 commented 1 year ago

CasaOS has done a large-scale refactoring of Docker compose in the past 2 months, and the current transition period has indeed led to the 2 results you mentioned. But please believe that we want to solve these two problems and bring back the hidden function, please give us some time. It is recommended that you delete or rebuild the app to be rebuilt right now. For other apps, we will provide the ability to group and hide apps later. @rodhammond

FurtzBR commented 1 year ago

I agree with the mess that legacy app visual is... I will briefly explain what happened to me.

I'm not an expert user but I had problems with Home Assistant from the appstore because it's a container and that's where my problem starts because there's no way to restore my backups in a simple and quick way!

By other means I managed to install the Supervised version for Debian outside of CasaOS and it is working normally now but when opening the CasaOS homepage this appears: Legacy app (To be rebuilt). and with everything I did outside the appstore.

Ok, I understand that there are improvements but if you only have one HIDE option, the Legacy app will solve this problem.

Visually it will look better and today there is no such option and every time I open it there is this visual dirt.

Cherrs from Brazil

levensailor commented 1 year ago

New to CasaOS and found this. I'm an infrastructure / devops guy who dabbles in programming and I wish I had time to take this on.

So, extend the state to include a condition for showing legacy app to line 69 on AppSection.vue

widget settings are in state "settingsData" and iterates item and give item.name, item.show state called

JimCallahanOrlando commented 1 year ago

IMO this is ridiculous. Before I move the Docker installation to the larger filesystem; I wanted to test the default installation. So, I ran (from an SSH session in Windows Terminal) sudo docker run hello-world and got the expected results. "Hello from Docker! This message shows that your installation appears to be working correctly." Then I go back to the CasaOS dashboard in my browser and I see the "Legacy app (To be rebuilt)" competent_borg At first I think it is malware. After some Google-ing I realize that it is the random name the Docker daemon assigned! I verify this by running sudo docker logs competent_borg And I get a repeat of: "Hello from Docker! This message shows that your installation appears to be working correctly." PROBLEM: CasaOS is offering to rebuild "Hello-World", but does this by a random session name? SOLUTION: Either uses the container name ("Hello-World") or both the container name AND the random session name ("competent_borg"), BUT not the random session name alone (as is currently the case). The problem is the random session names changes every time one runs the container so the next time might be "furious_archimedes" and is very confusing to users expecting consisten names like those in the app store.

FurtzBR commented 10 months ago

come guys please fix this issue!!!! i cant delete it, it will damage my Home Assistant Supervised.

we want to HIDE this

helderjnpinto commented 10 months ago

From my perspective, I also agree with hiding this.

SpookOz commented 10 months ago

ntainers that do not work or cannot be imported into CasaOS, your "Legacy app (To be rebuilt)" message cannot be hidden or disabled. Please re-enable the visibility feature. I could be mistaken, but believe it use to be selectable by the user.

I think your situation is a little different. In your case, you didn't stipulate a name when you created the container "hello-world" is the image name, not the container name. If you don't stipulate a container name, Docker gives your container a random name (in your case "competent_borg"). CasaOS is displaying the container name. If you want the container name to be "hello-world", the command should be: sudo docker run --name='hello-world' hello-world. You can test this by running docker container ls --all. That will show you the real names of your docker containers. They should be the same as what you see in CasaOS.

dncntn commented 1 month ago

We have news on this topic? Also I would get free from these messages "Legacy app (To be rebuilt)"

Dwouglaz commented 1 month ago

tambem estou com esse problema

tano70 commented 1 week ago

some problem in my configuration "legacy app ( to be rebuild) ". Any solution?

Elvynia commented 10 hours ago

I landed here after having the "Legacy app (to be rebuild)" section showing in my dashboard. It's my first install of CasaOS and I could not find information on why I had a legacy app showing up. Especially because of the silly/suspicious name admiring_mcnulty of that app that didn't help on researching. I wanted to do the obvious thing, rebuild that app like suggested but there was no menu on it.

Thanks to @JimCallahanOrlando's comment I was able to understand what was happening: I used the docker hello-world container ! So all you have to do to fix this is to remove your hello-world container. Be careful that it's not running so you have to use sudo docker ps -a to see it. Grab the hello-world container id and use sudo docker rm $id. This should get rid of your legacy app section instantly. Hope this can help some people.