search

IceWreck / Gnome-DAV-Support-Shim

CardDAV, CalDAV, etc support for GNOME
MIT License
40 stars 3 forks source link

Made more generic / reusable #1

Closed pcrockett closed 3 years ago

pcrockett commented 3 years ago

First of all, this is a great solution to the lack of GNOME DAV support. I was thinking I'd like to use this without changing the source. If you were wanting to keep this a small personal project for yourself with hard-coded values, no worries. Just close the PR and I'll be fine.

Summary of what I've done:

  1. Created command line arguments -cal and -card to allow for custom URLs.
  2. For well-known services like Fastmail, you can just use "fastmail" for these arguments. If no arguments are specified, it defaults to Fastmail. I also added a convenient place in the code for people to add more well-known URLs to the code via pull requests.
  3. Created an install script that sets up a systemd service so the shim starts automatically on login.
  4. Created a "release" section in the makefile that bundles everything up into releasable zip files.
  5. Updated readme with steps on how to use it.

Disclaimer: I'm not a Go developer (yet).

IceWreck commented 3 years ago

Hey @pcrockett

Thanks for this. I tested it and it works like a charm. Do you want to make any further changes or should I merge it now ?

Thanks again !

pcrockett commented 3 years ago

Cool, glad you like it. I think I'm finished, go for it. I don't know how you feel about the download URL in the README - feel free to update that for your own repo after the merge.