search

Icehawk78 / FrozenCookies

An automated Cookie Clicker tool.
120 stars 169 forks source link

Auto Clicking improvements #9

Closed matthewbegun closed 10 years ago

matthewbegun commented 11 years ago

Hey thanks for the great work guys.

I just wanted to let you know I've been playing around with the auto clicking stuff and trying to get the recommendation list to take autoclicking into account.

Here's what I've done - if you like please feel free to introduce. Added the following to upgradeStats() : 

 var clickCpsOrig = 1000 / cookie_click_speed * Game.mouseCps();
 var cpsOrig = baseCpsOrig + gcPs(weightedCookieValue(true)) + clickCpsOrig;

and

  var clickCpsNew = 1000 / cookie_click_speed * Game.mouseCps();
  var cpsNew = baseCpsNew + gcPs(weightedCookieValue(true)) + clickCpsNew;

My version is now prioritizing cursors and mouse upgrades as appropriate.

If that looks really wrong could you please let me know?

Cheers, Matt

Icehawk78 commented 11 years ago

The primary thing I'd do is extract this into its own function, so that you can have an immediate override for when clicking is turned off (since 1000 / 0 will blow up, and cookie_click_speed is set to 0 when autoclick is turned off.)

You'll also need to alter the weightedCookieValue to value clicking frenzies and normal frenzies by more utilising this, as well.

However, other than that, this is basically what needs to be added, I've mostly just been delaying adding the code since I've been adding other features that are actually usable/visible before I get the new UI elements working. If you'd like to fork and update this, and then submit a pull request when it's done, let me know, and I'll integrate it once I get it.

matthewbegun commented 10 years ago

I never actually got around to doing this properly (busy at work). And now I see its been added already.

I'm going to have a play around with the new code but some basic testing seems to indicate that the frequency isn't working correctly (at least on my pc). I believe this is a javascript issue, but if its not clicking as often as it says it is then clicking related upgrades will be overvalued by FC - for example in 10 seconds it clicks about 140ish times on my pc while valuing upgrades at the full 250. Turning the speed down however also lowers the number of clicks.

Not sure if that language made sense, but I'll have a poke at how its implemented.