search

IchHabRecht / filefill

Find and fetch missing local files from different remotes
GNU General Public License v2.0
63 stars 34 forks source link

Add new resources handler 'ascii' #48

Closed kitzberger closed 2 years ago

kitzberger commented 2 years ago

Add new resources handler 'ascii', to fake content of ascii files such as *.youtube and *.vimeo

Resolves: #47

baschny commented 2 years ago

👍

IchHabRecht commented 2 years ago

Hi @kitzberger,

Thank you for your merge request. As commented in #47 I can't find any problem with media files currently. Furthermore your approach would not load the expected video but a hard-coreded one which might result in unexpected behaviour for other people. If you want to offer additional resource handler for filefill I highly recommend to join forces with @baschny (#44) and create an own extension for filefill resource handler that can be used by other people as well.

baschny commented 2 years ago

@IchHabRecht I discussed this with Philipp, and indeed my first impuls was also to integrate that into our own extension. But on the other hand, filefill is currently not shipping with any meaningful "replacement strategy" for video (or .txt files), and this would be a very simple one to start with. Currently the extension is not really "filefill", its only "imagefill" :) - and we thought that it would thus make sense to integrate this simple one to the core of the extension already, since it does not depend on any other external sources. The "hard-coded" video is configurable and it might be more expected to see a "video" instead of seeing an exception (or no content at all) where videos are expected (in case we do not have any fileadmin synchronisation from the live-system).