search

IchHabRecht / filefill

Find and fetch missing local files from different remotes
GNU General Public License v2.0
63 stars 34 forks source link

Cropping / Imagemanipulation does not work in Frontend #51

Closed timwehrmann closed 2 years ago

timwehrmann commented 2 years ago

Hey @IchHabRecht

thanks for this great extension. It helps a lot with getting a local system running without syncing the entire fileadmin, really love it :D

Nevertheless I encountered a problem in two separate instances: Images are cropped with a fixed format using the default TYPO3 image manipulation on the leading TYPO3 instance. The image is cropped and comes out of _processed_ folder as intended.

On my local instance the original file is taken instead without cropping in frontend. This seems to be nothing but a frontend issue since the cropping mask in sys_file_reference is the same on both systems - so from backend perspective everything looks good AFAICS. If I save the cropping and the record / sys_file_reference without changing anything, then the image in frontend gets displayed with cropping like on the leading instance and stays like this - so plain saving seems to fix it.

Sadly I cannot hand in a PR with this issue due to not having time yet. Maybe I dig into this later, but before I forget about this I wanted to post it here.

IchHabRecht commented 2 years ago

Hi @timwehrmann,

Thank you very much for your issue. Unfortunately I have to tell you, that filefill is designed to not handle any processed files by itself. If the original file is available the file processing can be done locally. As I don't know anything about your project and/or configuration I'm not able to help with this issue.

timwehrmann commented 2 years ago

The file gets synced, that is not the problem - dont get me wrong there. The problem is that in both projects only those files that got synced with Filefill are not able to be processed while those that are added manually can be (by both Backend and plain rsync). Interesting part is that it gets fixed by saving the record without having any changes at all. I will dig into this later (today / tomorrow), maybe I'll find out (either I close it or I come up with a PR :D)

timwehrmann commented 2 years ago

tl;dr: Seems to be a project-wise problem → closed.

I set up a plain TYPO3 11 using PHP 7.4 with introduction package.

On "Congratulation" page [id=1] I added a new slide with an background image with a cropping area in the very left bottom corner:

image image

I open now the frontend on remote system and everything works as intended - the cropped image is shown:

image image

Now I synced the database to my local system, the file does not exist at that point there. I then open the frontend and in the very plain TYPO3 11 the file gets displayed cropped just as on remote system 🥳

In the instances I've spoken of this does not happen, the original file gets displayed without the cropping. So the filefill mechanism works but somehow TYPO3 does not process the file. It does if you do one of two things: Either save the record in which the cropped image is placed or get the file to the system the CLI way using scp and / or stuff. In any way this is not a problem of filefill as far as I can say.