search

IchHabRecht / filefill

Find and fetch missing local files from different remotes
GNU General Public License v2.0
63 stars 34 forks source link

Compatibility with Symfony 7 #77

Open linawolf opened 8 months ago

linawolf commented 8 months ago

When running on TYPo3 v 12.4 with Symfony 7 I get a fatal errors:

PHP Fatal error: Declaration of IchHabRecht\Filefill\Command\ResetCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony \Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /var/www/html/vendor/ichhabrecht/filefill/Classes/Command/Reset Command.php on line 52

Fatal error: Declaration of IchHabRecht\Filefill\Command\ResetCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Comp onent\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /var/www/html/vendor/ichhabrecht/filefill/Classes/Command/ResetComma nd.php on line 52

linawolf commented 8 months ago

Adding :int as return value to all execute methods in command solves the problem locally

linawolf commented 8 months ago

filefill-symfony7.patch

IchHabRecht commented 8 months ago

Hi @linawolf

Thank you for your issue. This problem should be fixed with the latest 4.3.1 release of filefill.